microsoft / microsoft/AdaptiveCards

Revisit accessibility solution in https://github.com/microsoft/AdaptiveCards/pull/6763#issuecomment-1171999511

Open
#7,604 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Accessibility Bug
Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

Revisit https://github.com/microsoft/AdaptiveCards/pull/6763#issuecomment-1171999511
@compulim

(I know not many people will read comments in merged/closed PRs. But I will just keep it here.)

IMO, role="toolbar" is a better role for grouping buttons. Some screen readers read "1 of 6" even without aria-posinset for things inside role="toolbar".

Turning a button into menu item hurts accessibility as shortcut keys that normally applies to buttons (and form fields) will no longer apply to menu item. Say, pressing B or F in Narrator will jump to the next closest button. However, it won't jump to button[role="menuitem"].

Buttons in toolbar are still buttons. Buttons in menu bar are no longer buttons. Better to stay as close to its original form as possible.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the accessibility discussion in PR #6763, especially the linked comment, and locate the implementation that assigns roles to grouped buttons. Determine the intended role behavior and validate it with the project's accessibility coverage; done means the agreed role preserves expected screen-reader and keyboard behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
accessibility
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.