microsoft / microsoft/AdaptiveCards
Update Outdated Template Samples
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Issue
A couple of the template samples appear to be outdated in samples/Templates/Scenarios.
-
Newline is accessed incorrectly. The template uses
\\n, and the correct usage is\n. -
The given images are not rendering. I believe the provided URLs are out of date.
-
check inner double quotes usages. https://github.com/microsoft/AdaptiveCards/blob/9c0bdd27d3bbd9ca973e68d2227c445e61759450/samples/Templates/Elements/Template.data.json#L38
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with samples/Templates/Scenarios/FlightDetails.template.json and FoodOrder.template.json, checking the newline escaping and whether the image URLs still render. Also inspect the inner double-quote usage in samples/Templates/Elements/Template.data.json around line 38. Done means the sample templates parse correctly and the referenced images and text display as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- json
- Domain
- content
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100