microsoft / microsoft/AdaptiveCards

[JS] Enable test-adaptive-card-schema test on js-ci pipeline

Open
#6,882 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

test-adaptive-card-schema is disabled in #6833

https://microsoft.visualstudio.com/AdaptiveCards/_build/results?buildId=43693304&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=dee4e6ec-be1b-5671-4678-ab293b4004c5

schema id ignored http://adaptivecards.io/schemas/adaptive-card.json
D:\a\1\s\source\nodejs\tests\test-adaptive-card-schema\node_modules\ajv\lib\ajv.js:93
if (!v) throw new Error('no schema with key or ref "' + schemaKeyRef + '"');
^

Error: no schema with key or ref "http://json-schema.org/draft-06/schema#"
at Ajv.validate (D:\a\1\s\source\nodejs\tests\test-adaptive-card-schema\node_modules\ajv\lib\ajv.js:93:19)
at Ajv.validateSchema (D:\a\1\s\source\nodejs\tests\test-adaptive-card-schema\node_modules\ajv\lib\ajv.js:174:20)
at Ajv._addSchema (D:\a\1\s\source\nodejs\tests\test-adaptive-card-schema\node_modules\ajv\lib\ajv.js:307:10)
at Ajv.compile (D:\a\1\s\source\nodejs\tests\test-adaptive-card-schema\node_modules\ajv\lib\ajv.js:113:24)
at Object. (D:\a\1\s\source\nodejs\tests\test-adaptive-card-schema\lib\test-adaptive-card-schema.js:10:20)
at Module._compile (internal/modules/cjs/loader.js:1085:14)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
at Module.load (internal/modules/cjs/loader.js:950:32)
at Function.Module._load (internal/modules/cjs/loader.js:790:12)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
##[error]Bash exited with code '1'.
Finishing: Build and run test in tests/[test-adaptive-card-schema]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/test-adaptive-card-schema/lib/test-adaptive-card-schema.js and the test's package configuration, then run test-adaptive-card-schema to reproduce the missing draft-06 schema error. Check the js-ci pipeline entry that runs this test; done means the test is enabled there and completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
ci-cd, testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.