microsoft / microsoft/AdaptiveCards

[JS] test failures in carousel.spec.ts

Open
#6,874 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Platform-JavaScript
Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

Details in
https://microsoft.visualstudio.com/AdaptiveCards/_build/results?buildId=43488759&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=35f53584-79fc-539f-463c-6471d0663a3a

FAIL src/__tests__/components/carousel.spec.ts (8.015 s)
  carousels
    when default constructed
      ✓ should have reasonable default values (4 ms)
    when parsed from a valid object
      ✓ shouldn't throw exceptions (2 ms)
      ✕ should have all of its expected properties and child elements (1 ms)
      ✕ shouldn't allow anything in pages but CarouselPages (1 ms)
    certain elements
      ✕ shouldn't be allowed within a Carousel (4 ms)
  carousel pages
    ✓ shouldn't be parseable outside of a Carousel (1 ms)

  ● carousels › when parsed from a valid object › should have all of its expected properties and child elements

    TypeError: Cannot read property 'timer' of undefined

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/tests/components/carousel.spec.ts and run the carousel test suite to reproduce the reported failures. Inspect the setup behind the valid-object parsing test and the failing assertions, then confirm that all five previously failing cases pass without breaking the passing cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.