microsoft / microsoft/AdaptiveCards

Use sass to support dark theme and light theme.

Open
#6,711 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Task
Dominant language
C#
Stars
2k
Forks
595
Avg merge
1d 19h
Merged PRs (30d)
1

Description

When I change the size of berlin conf, I need to change two places.
Likely we can use sass preprocessor to mix them with @use 'base or @include
https://ampersandtutorials.com/sass/light-and-dark-theme-using-mixin/
https://sass-lang.com/guide

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the Berlin conf theme styles and the two places that currently require size changes, then review the linked Sass guide and mixin tutorial. Done means dark and light theme styling can be maintained through Sass without duplicating those changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
sass
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.