microsoft / microsoft/AdaptiveCards
[JS] Use `sass` to generate our css outputs
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
We currently have a .scss file checked in for the adaptivecards package (source/nodejs/adaptivecards/scss), but it doesn't appear that we consume it. It's also pretty out of date relative to the vanilla CSS file we ship (source/nodejs/adaptivecards/src/adaptivecards.css). We should:
- Update the
.scssfile - Import swiper's scss
- [ ] Updatewebpack.config.jsto usesass-loaderto consume the.scss - Clean up existing scss files
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the SCSS files under source/nodejs/adaptivecards/scss with source/nodejs/adaptivecards/src/adaptivecards.css, then inspect webpack.config.js and the sass-loader note. Review which existing SCSS files still need cleanup; done means the SCSS sources are current, include the referenced Swiper SCSS, and no obsolete files remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- sass, webpack
- Domain
- build-system, frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100