microsoft / microsoft/AdaptiveCards
[Rendering] DotNet AdaptiveVisitor is out of date and doesn't support all of the new schema elements.
Open
Nobody has claimed this yet.
Area-Schema
Request
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Target Application
Microsoft Teams
Application Operating System
Windows
Schema Version
1.4
Problem Description
AdaptiveVisitor.cs is out of date and doesn't have visitor patterns for many new elements.
- SelectAction is not navigated to
- RichText, IlineRuns etc are not navigated to
- inlineAction is not navigated to
Expected Outcome
Visitor should visit all element types as schema changes.
Actual Outcome
new element types and properties are not navigated to.
Card JSON
{}
Repro Steps
Try and visit SelectActions
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with AdaptiveVisitor.cs and compare its visitor patterns with the schema 1.4 elements named in the report: SelectAction, RichText, IlineRuns, and inlineAction. Confirm how SelectActions are currently visited, then update coverage so the visitor reaches these new element types and properties; done means each reported element is navigated to.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100