microsoft / microsoft/AdaptiveCards
[Rendering][iOS]SDK doesn't support placeholder image and then Posting notification for when the actual image comes back from a service request
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Target Platform
Please list the platform(s) that your application is targeting and remove platforms you are not targeting:
- iOS
Target Application
Please provide the name of the application that is rendering the card (ex: Outlook, Teams, etc)
Teams
Problem Description
The current SDK 2.8.0-beata1 doesn't support posting a notification after a placeholder has been assigned to the UIImageView, as when the placeholder is assigned to an imageView, it also posts a notification which calls the - (void)configUpdateForUIImageView:(ACRView *)rootView acoElem:(ACOBaseCardElement *)acoElem config:(ACOHostConfig *)acoConfig image:(UIImage *)image imageView:(UIImageView *)imageView function inside the ACRImageRenderer and hence removing the observer, so when the actual image comes back from the backend service, the delegate function never gets called. Hence constraints stay with respect to the Placeholder image
Please enter a description of the issue. If you just have a question, please post on StackOverflow instead
Screenshot
Please provide a screenshot of the problem (if possible)
Card JSON
Please provide the JSON of the Card that is being rendered
Sample Code
Please provide any relevant code samples to help reproduce the issue
Version of SDK
What version are you using? Ex: NuGet 1.0.2, or latest main, etc...
2.8.0-beata1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ACRImageRenderer, especially configUpdateForUIImageView:acoElem:config:image:imageView:, and trace how the placeholder and service response are observed. Reproduce the image loading sequence using the stated SDK version; done means the actual image triggers the delegate notification and the image view constraints update accordingly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, objective-c
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100