microsoft / microsoft/AdaptiveCards
[All][Consistency] Shared model should not throw exceptions for invalid adaptive cards
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2k
- Forks
- 595
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 1
Description
Update parsing behaviors such that exception is not thrown when empty or null value is given for a property even when the property "required". For example, If value for url of Image is missing or empty, parsing the string for url should not yield an exception by the parsers. Elements should be dropped by the parser in this case.
For more detailed procedure of handling improper values. please see here
See also: #4565
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked Inconsistencies.md design discussion and the related issue #4565, then trace the shared model parsers for required properties such as Image.url. Done means empty or null values no longer throw during parsing and affected elements are dropped consistently across the parsers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100