Export APSI::apsi with the JsonCpp::JsonCpp target
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 212
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Description
APSI's exported APSI::apsi target links the bare CMake target jsoncpp_static. With vcpkg's dynamic jsoncpp build, that target is not defined; the package provides the stable JsonCpp::JsonCpp target instead. As a result, a downstream find_package(APSI CONFIG REQUIRED) consumer configures but fails to link with jsoncpp_static.lib not found.
Replacing jsoncpp_static with JsonCpp::JsonCpp in target_link_libraries(apsi ...) fixes both Release and Debug consumers while continuing to work with jsoncpp's installed CMake package.
This was found while validating microsoft/vcpkg#53313.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the CMake target_link_libraries(apsi ...) declaration and inspect how the exported APSI::apsi target refers to jsoncpp. Validate a downstream find_package(APSI CONFIG REQUIRED) consumer with vcpkg's dynamic jsoncpp build in both Release and Debug; done means both configurations link without a missing jsoncpp_static.lib.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 84/100