microsoft / microsoft/ALAppExtensions

Modify Event OnBeforeCheckBlockedCust on Customer Table

Open
#29,640 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

event-request ext-ready-to-implement SCM
Dominant language
AL
Stars
988
Forks
692
Avg merge
49m
Merged PRs (30d)
1

Description

Why do you need this change?

Since the document Type is an Enum, I think that also the OnBeforeCheckBlockedCust Event, on Customer Table, should accept the enum as parameter and not an option.

Extending then Sales Document Enum or the Blocked enum can generate an error trying to extend the blocked control

Describe the request

the procedure

local procedure IsOnBeforeCheckBlockedCustHandled(Customer: Record Customer; Source: Option Journal,Document; DocType: Enum "Gen. Journal Document Type"; Shipment: Boolean; Transaction: Boolean)
var
IsHandled: Boolean
begin
OnBeforeCheckBlockedCust(Customer, Source, DocType.AsInteger(), Shipment, Transaction, IsHandled)
end;
has the enum as parameter but the event has an option

[IntegrationEvent(false, false)]
local procedure OnBeforeCheckBlockedCust(Customer: Record Customer; Source: Option Journal,Document; DocType: Option; Shipment: Boolean; Transaction: Boolean; var IsHandled: Boolean)
begin
end;

should be

[IntegrationEvent(false, false)]
local procedure OnBeforeCheckBlockedCust(Customer: Record Customer; Source: Option Journal,Document; DocType: Enum "Gen. Journal Document Type"; Shipment: Boolean; Transaction: Boolean; var IsHandled: Boolean)
begin
end;

Internal work item: AB#620150

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the IsOnBeforeCheckBlockedCust procedure and the OnBeforeCheckBlockedCust event declaration described in the issue, then trace their callers and subscribers. Done means the event parameter uses Enum "Gen. Journal Document Type" consistently with the procedure and the affected code remains compatible.

Written by the indexing model from the issue text.

Assessment

Domain
backend-api-design
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.