microsoft / microsoft/AL-Go

[Bug]: AL-Go docker pruning too aggressive(?)

Open
#1,675 7 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

  • #1828 by @spetersenms — closed without merging
bug Fix Ready stale
Dominant language
PowerShell
Stars
506
Forks
203
Avg merge
4d 22h
Merged PRs (30d)
6

Description

AL-Go version

6.3

Describe the issue

We have a private Azure VM we've been using for the past year to unit test development tickets (for both saas and onprem apps). The docker instances on that VM are created via bccontainerhelper with the usetraefik option.

last week we installed self-hosted github runners on the same VM (because our standard github-hosted runner build pipelines were failing for apps with large third party dependencies)

My team alereted me this morning that ALL BC containers on that VM are GONE (both saas and onprem containers).

Are the AL-GO self-hosted runners performing any container cleanup/housekeeping? If so, it appears the current housekeeping that is implemented in algo/bccontainerhelper is far too agresssive (why its pruning containers NOT created by AL-Go itself is beyond me).

Please consider adding in settings to whitelist by wildcard which containers AL-GO should and shouldnt touch.

Please advise.

The self-hosted runner documention BTW doesn't mention any risks of running a self-hosted runner on a server where bccontainerhelper is actiively used locally.

Expected behavior

al-go/bccontainerhelper shouldn't touch/purge BC containers not spun up by AL-Go

Steps to reproduce

create a docker container (saas or onprem) on a machine via bccontainerhelper. next, install a self-hosted runner on the same machine. I don't know the details beyond that, but eventually the self-hosted runner will kill off the BC Container previously created (by docker container creation date?)

Additional context (logs, screenshots, etc.)

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.