micropython / micropython/micropython
RP2 SPI: Instantiating with spi=None does not behave sensibly.
Open
Nobody has claimed this yet.
bug
port-rp2
- Dominant language
- C
- Stars
- 22.1k
- Forks
- 9k
- Avg merge
- 6d 4h
- Merged PRs (30d)
- 16
Description
The constructor accepts None as an arg to miso, but still instantiates the default pin.
The clear intent is to create an output-only interface. Either it should reject the arg or (preferably) it should not instantiate a pin. Current behaviour can lead to unexpected pin conflicts.
This should also apply to mosi.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the RP2 SPI constructor and trace how miso=None and mosi=None are handled when pins are initialized. Confirm the intended output-only behavior and add or update the relevant RP2 SPI tests so the default pins are not instantiated for either argument.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, python
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100