micropython / micropython/micropython-lib

requests do not works in mutithread, breaks the whole script/device

Open
#772 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.9k
Forks
1.1k
Avg merge
7d 6h
Merged PRs (30d)
3

Description

A simple script like this, breaks the whole script or device when trying to make requests from two works ¿? I dont know exactly how to call the problem but you can replicate it easily.

Im using MicroPython v1.21.0 on 2023-10-06; Raspberry Pi Pico W with RP2040

The main loop can work fine forever (pinging the url) but as soon as i press the button it breaks with this random behaviors:

  1. Main loop requests hangs and remains until timeout, i can raise timeout to hours and request still hanged forever, 2nd thread request go out fine for one time but if i press button again it just hangs too and it just hangs forever until reboot device
  2. Main loop request hangs forever and button requests works fine every-time i press button
  3. Button requests pass fine for one time, then it hangs but Main loop request works fine forever

I have been trying to make it works for 1 week and it just don work, what i tried:

Using thread.allocate_lock()
Making two request functions (one for main loop one for button press request)
make a clone of request library and import it with a different name, then calling the requests library from main loop and the cloned library from button request
using other gpio button (not the bootsel button)
use the 2nd thread function without button (making it automatically with a sleep times)

All tries ended on the same problem, also i have use a longer sleep times for the main loop and press the button to call the request function some minutes after the main loop ended and it do the same

It seems (at my poor knowledge on python) that requests library do not "release" (or close) at all the requests and it leave only available for the first core that use it?

How can i make it works with this two threads functions?

import utime, _thread, ujson, requests, network

ssid_name = 'xxx'
ssid_pass = 'xxx'
wlan = network.WLAN(network.STA_IF)
wlan.active(True)

def make_http_request(url):
    print("request entry")
    r = None
    response_data = None
    try:
        print("trying block")
        r = requests.get(url, timeout=10)
        response_data = ujson.loads(r.text)
        r.close()
        return response_data
    except Exception as e:
        print("Error:", e)
        raise
    finally:
        if r is not None:
            r.close()
                
def bootsel():
    import rp2
    while True:
        if rp2.bootsel_button() == 1:
            print("pressed")
            but_data = make_http_request("https://httpbin.org/get")
            print(f"But: {but_data}")

_thread.start_new_thread(bootsel,())
while True:
    if wlan.isconnected():
        print("connected.. pinging")
        ping = make_http_request("https://httpbin.org/get")
        print(f"Ping: {ping}")
        print("sleeping")
        utime.sleep(45)
    else:
        time=0
        while not wlan.isconnected():
            print ('connecting...')
            wlan.connect(ssid_name, ssid_pass)
            while not wlan.isconnected():
                time = time + 1
                print(f'waiting connection {time}')
                utime.sleep_ms(1000)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the supplied script on MicroPython v1.21.0 with a Raspberry Pi Pico W, focusing on make_http_request, bootsel, _thread, and requests.get. Compare the main-loop and button-triggered requests, including the reported hangs, and use successful repeated requests from both paths as the completion criterion.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
embedded-iot, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.