micropython / micropython/micropython-lib
urequests doesn't handle basic auth formatted URLs correctly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 1.1k
- Avg merge
- 7d 6h
- Merged PRs (30d)
- 3
Description
Per RFC1738 you can supply a username and password for basic auth as part of the URL in the format: http(s)://username:password@example.com however urequests interprets any colon following the protocol to be delimiting a host and port, as seen here.
Obviously it's simple to provide basic auth as a header instead, but it's probably best to be RFC compliant when possible.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in python-ecosys/urequests/urequests.py at the URL parsing code around line 72, then compare its handling with the RFC1738 username:password@example.com format. Verify that URLs containing basic-auth credentials are no longer treated as host-and-port URLs and that existing URL handling remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100