micropython / micropython/micropython-lib
`logging.FileHandler` not adding new lines to log file
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 1.1k
- Avg merge
- 7d 6h
- Merged PRs (30d)
- 3
Description
Just tried the updated logging module to replace the StreamHandler and FileHandler adapted from CPython that I was previously using. Thank you @iabdalkader for this update.
StreamHandler works as expected, however I noticed that I wasn't getting any new lines in my log file.
I looked at the previous code and saw that there's a flush after the write in StreamHandler.emit.
Using this subclass for FileHandler, it works like before:
class MyStreamHandler(StreamHandler):
def flush(self):
if self.stream and hasattr(self.stream, "flush"):
self.stream.flush()
def emit(self, record):
super().emit(record)
self.flush()
Is there a reason for not doing a flush in emit, maybe something specific to MicroPython that I'm not aware of?
- MicroPython and board:
MicroPython v1.19.1-915-g2bcd88d55 on 2023-03-02; Raspberry Pi Pico W with RP2040 loggingversion:0.5installed withmip
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the updated logging module on the reported MicroPython Raspberry Pi Pico W setup, then compare FileHandler with StreamHandler.emit and the previous adapted implementation. Done means FileHandler log output is available as expected without the custom flush subclass; check existing logging tests if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100