micropython / micropython/micropython-lib
PINGRESP ignored in umqtt.simple.py
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 1.1k
- Avg merge
- 7d 6h
- Merged PRs (30d)
- 3
Description
Hello,
In wait_msg, the PINGRESP message is ignored:
if res == b"\xd0": # PINGRESP
sz = self.sock.read(1)[0]
assert sz == 0
return None
Shouldn't this return some information so that the calling code can determine if the server is indeed responding to pings?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names umqtt.simple.py and the wait_msg entry point. Start by reading wait_msg and its callers to understand how message results are currently handled, then check whether existing tests or examples cover PINGRESP behavior. Done means callers can determine that a ping response was received without breaking other wait_msg cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100