micrometer-metrics / micrometer-metrics/prometheus-rsocket-proxy

Prometheus RSocket Client not initialized when spring.main.lazy-initialization=true

Open
#83 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
77
Forks
30
PR merge metrics
No merged PRs in 30d

Description

Currently we have an issue that the `PrometheusRSocketClientAutoConfiguration` does not initialize the `PrometheusRSocketClient` when the `lazy-initialization` is set to `true`.

I guess this is because `PrometheusRSocketClient` is not required anywhere due to autowiring.

Suggestion would be to add `@Lazy(false)` and test if this is working in this case.

@onobc / @jonatan-ivanov WDYT?

Contributor guide

Open the contributing guide

Research direction

Start in PrometheusRSocketClientAutoConfiguration and reproduce the issue with spring.main.lazy-initialization=true. Check whether PrometheusRSocketClient is initialized without autowiring, then verify that the proposed @Lazy(false) behavior works in this configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
observability
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.