micromatch / micromatch/picomatch

Regression since 2.1.1

Open
#59 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.3k
Forks
135
Avg merge
23h 38m
Merged PRs (30d)
7

Description

👋 thanks for your hard work on this package.

I have patterns like this:

'**/__tests__/**/__{helper|fixture}?(s)__/**/*',
'**/test?(s)/**/{helper|fixture}?(s)/**/*'

With the latest release these no longer match.

I'm trying to wrap up a release so don't have the time to make an isolated reproduction, but if you check out this PR and revert the last commit, and then run npx tap --no-cov test/globs.js you should see the test failures.

Let me know if you'd like more details and I'll try and find the time to help out. Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/globs.js and the linked AVA PR #2341; compare the behavior before and after its last commit. Run npx tap --no-cov test/globs.js and verify that the reported brace and extglob patterns match again without the test failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.