microg / microg/GmsCore

Share Now App does crash because of some maps api stuff (logcat attached) works with stock gapps

Open
#988 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
14.6k
Forks
3.2k
Avg merge
12d 11h
Merged PRs (30d)
4

Description

Hi,
I have the problem that the Share Now App does crash because of some gms.maps stuff, I talked with their devs and they said that it is caused by some Polygon forms which microg is not able to handle.
Here the logcat
2019-12-10 11:08:34.874 32722-32722/com.car2go E/AndroidRuntime: FATAL EXCEPTION: main Process: com.car2go, PID: 32722 java.lang.RuntimeException: Unable to resume activity {com.car2go/com.car2go.activity.MainActivity}: java.lang.IllegalArgumentException: fromIndex(0) > toIndex(-1) at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3823) at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3855) at android.app.servertransaction.ResumeActivityItem.execute(ResumeActivityItem.java:51) at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:145) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:70) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1817) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6724) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:495) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858) Caused by: java.lang.IllegalArgumentException: fromIndex(0) > toIndex(-1) at java.util.ArrayList.subListRangeCheck(ArrayList.java:1018) at java.util.ArrayList.subList(ArrayList.java:1008) at org.microg.gms.maps.mapbox.model.PolygonImpl.setHoles(Unknown Source:302) at com.google.android.gms.maps.model.internal.IPolygonDelegate$Stub.onTransact(Unknown Source:256) at org.microg.gms.maps.mapbox.model.PolygonImpl.onTransact(Unknown Source:0) at android.os.Binder.transact(Binder.java:667) at com.google.android.gms.internal.maps.zza.transactAndReadExceptionReturnVoid(Unknown Source:7) at com.google.android.gms.internal.maps.zzy.setHoles(Unknown Source:8) at com.google.android.gms.maps.model.Polygon.setHoles(Unknown Source:2) at com.car2go.maps.google.adapter.PolygonAdapter.setHoles(PolygonAdapter.java:1) at com.car2go.map.t0.h.b(SpecialZoneLayer.java:24) at com.car2go.map.t0.h.a(SpecialZoneLayer.java:10) at com.car2go.map.t0.f.a(PolygonLayers.java:7) at com.car2go.map.MapView.onResume(MapView.java:6) at com.car2go.activity.MainActivity.onResume(MainActivity.java:4) at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1412) at android.app.Activity.performResume(Activity.java:7300) at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3815) at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3855) at android.app.servertransaction.ResumeActivityItem.execute(ResumeActivityItem.java:51) at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:145) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:70) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1817) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6724) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:495) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Thanks for help

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading org.microg.gms.maps.mapbox.model.PolygonImpl.setHoles, using the attached stack trace and the call from com.car2go.maps.google.adapter.PolygonAdapter.setHoles as the reproduction path. Check the maps polygon handling involved during MainActivity.onResume; done means the Share Now app no longer crashes when its polygon holes are set.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.