microg / microg/GmsCore

Flightradar24 crashes on mapbox

Open
#850 12 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
14.6k
Forks
3.2k
Avg merge
12d 11h
Merged PRs (30d)
4

Description

com.flightradar24free crashes on mapbox if I change any settings (e. g. switch the map type). This didn't use to be the case before the mapbox update:

 Mbgl-MapChangeReceiver  E  Exception in onDidFinishLoadingStyle
                         E  java.lang.ClassCastException: java.lang.Object cannot be cast to com.mapbox.mapboxsdk.plugins.annotation.Annotation
                         E  	at com.mapbox.mapboxsdk.plugins.annotation.AnnotationManager.update(AnnotationManager.java:201)
                         E  	at org.microg.gms.maps.mapbox.GoogleMapImpl$applyMapType$update$1.invoke(GoogleMap.kt:214)
                         E  	at org.microg.gms.maps.mapbox.GoogleMapImpl$applyMapType$update$1.invoke(GoogleMap.kt:58)
                         E  	at org.microg.gms.maps.mapbox.GoogleMapKt$sam$com_mapbox_mapboxsdk_maps_Style_OnStyleLoaded$0.onStyleLoaded(Unknown Source:7)
                         E  	at com.mapbox.mapboxsdk.maps.MapboxMap.notifyStyleLoaded(MapboxMap.java:846)
                         E  	at com.mapbox.mapboxsdk.maps.MapboxMap.onFinishLoadingStyle(MapboxMap.java:206)
                         E  	at com.mapbox.mapboxsdk.maps.MapView$MapCallback.onDidFinishLoadingStyle(MapView.java:1178)
                         E  	at com.mapbox.mapboxsdk.maps.MapChangeReceiver.onDidFinishLoadingStyle(MapChangeReceiver.java:194)
                         E  	at com.mapbox.mapboxsdk.maps.NativeMapView.onDidFinishLoadingStyle(NativeMapView.java:1040)
                         E  	at android.os.MessageQueue.nativePollOnce(Native Method)
                         E  	at android.os.MessageQueue.next(MessageQueue.java:325)
                         E  	at android.os.Looper.loop(Looper.java:142)
                         E  	at android.app.ActivityThread.main(ActivityThread.java:6494)
                         E  	at java.lang.reflect.Method.invoke(Native Method)
                         E  	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:440)
                         E  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
              libc++abi  E  terminating with uncaught exception of type jni::PendingJavaException
                   libc  F  Fatal signal 6 (SIGABRT), code -6 in tid 29510 (ightradar24free), pid 29510 (ightradar24free)
                  DEBUG  F  #00 pc 000000000001da90  /system/lib64/libc.so (abort+104)
                         F  #01 pc 0000000000379568  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #02 pc 0000000000379694  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #03 pc 000000000037748c  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #04 pc 0000000000376c14  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #05 pc 0000000000376b94  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #06 pc 0000000000037874  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #07 pc 000000000003bcc0  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #08 pc 00000000000a6390  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #09 pc 0000000000159840  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #10 pc 000000000015b09c  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #11 pc 00000000002c5b5c  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #12 pc 000000000008e380  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #13 pc 0000000000055e88  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #14 pc 0000000000056024  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #15 pc 00000000000541d8  /data/data/com.flightradar24free/cache/.gmscore/lib/arm64-v8a/libmapbox-gl.so
                         F  #16 pc 0000000000015fcc  /system/lib64/libutils.so (android::Looper::pollInner(int)+856)
                         F  #17 pc 0000000000015bec  /system/lib64/libutils.so (android::Looper::pollOnce(int, int*, int*, void**)+108)
                         F  #18 pc 000000000010f3b8  /system/lib64/libandroid_runtime.so (android::android_os_MessageQueue_nativePollOnce(_JNIEnv*, _jobject*, long, int)+44)
                         F  #19 pc 000000000078b86c  /system/framework/arm64/boot-framework.oat (offset 0x5af000) (android.app.NativeActivity.onWindowFocusChangedNative [DEDUPED]+140)
                         F  #20 pc 0000000000f13280  /system/framework/arm64/boot-framework.oat (offset 0x5af000) (android.os.MessageQueue.next+192)
                         F  #21 pc 0000000000f0d1a4  /system/framework/arm64/boot-framework.oat (offset 0x5af000) (android.os.Looper.loop+500)
                         F  #22 pc 00000000006719c0  /system/framework/arm64/boot-framework.oat (offset 0x5af000) (android.app.ActivityThread.main+880)
                         F  #23 pc 000000000054744c  /system/lib64/libart.so (art_quick_invoke_static_stub+604)
                         F  #24 pc 00000000000dc7b0  /system/lib64/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+260)
                         F  #25 pc 000000000046bb70  /system/lib64/libart.so (art::InvokeWithArgArray(art::ScopedObjectAccessAlreadyRunnable const&, art::ArtMethod*, art::ArgArray*, art::JValue*, char const*)+100)
                         F  #26 pc 000000000046d704  /system/lib64/libart.so (art::InvokeMethod(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, _jobject*, _jobject*, unsigned long)+1452)
                         F  #27 pc 00000000003f0ba4  /system/lib64/libart.so (art::Method_invoke(_JNIEnv*, _jobject*, _jobject*, _jobject*)+52)
                         F  #28 pc 00000000002588c4  /system/framework/arm64/boot.oat (offset 0x1d1000) (java.lang.Class.getDeclaredMethodInternal [DEDUPED]+180)
                         F  #29 pc 00000000015e89e4  /system/framework/arm64/boot-framework.oat (offset 0x5af000) (com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run+132)
                         F  #30 pc 00000000015f1a80  /system/framework/arm64/boot-framework.oat (offset 0x5af000) (com.android.internal.os.ZygoteInit.main+2864)
                         F  #31 pc 000000000054744c  /system/lib64/libart.so (art_quick_invoke_static_stub+604)
                         F  #32 pc 00000000000dc7b0  /system/lib64/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+260)
                         F  #33 pc 000000000046bb70  /system/lib64/libart.so (art::InvokeWithArgArray(art::ScopedObjectAccessAlreadyRunnable const&, art::ArtMethod*, art::ArgArray*, art::JValue*, char const*)+100)
                         F  #34 pc 000000000046b79c  /system/lib64/libart.so (art::InvokeWithVarArgs(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, _jmethodID*, std::__va_list)+420)
                         F  #35 pc 0000000000372a54  /system/lib64/libart.so (art::JNI::CallStaticVoidMethodV(_JNIEnv*, _jclass*, _jmethodID*, std::__va_list)+620)
                         F  #36 pc 00000000000a7010  /system/lib64/libandroid_runtime.so (_JNIEnv::CallStaticVoidMethod(_jclass*, _jmethodID*, ...)+120)
                         F  #37 pc 00000000000a9780  /system/lib64/libandroid_runtime.so (android::AndroidRuntime::start(char const*, android::Vector<android::String8> const&, bool)+832)
                         F  #38 pc 0000000000002440  /system/bin/app_process64 (main+1328)
                         F  #39 pc 00000000000a25b0  /system/lib64/libc.so (__libc_init+88)
                         F  #40 pc 0000000000001e70  /system/bin/app_process64 (_start_main+80)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in GoogleMap.kt at GoogleMapImpl.applyMapType, using the reported ClassCastException from AnnotationManager.update as the entry point. Reproduce the crash in Flightradar24 by changing a map setting such as the map type, then verify that style changes complete without the application crashing.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.