microg / microg/GmsCore

MapBox variant crashes when using QuickMap

Open
#839 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🗺 Maps bug confirmed
Dominant language
Java
Stars
14.6k
Forks
3.2k
Avg merge
12d 11h
Merged PRs (30d)
4

Description

It is possible that this is fixed by https://github.com/microg/android_packages_apps_GmsCore/commit/73fd85a8c7ff2762dd615f3a5caa9d9f1db2b6f5

But just in case it is a different issue, I am getting a crash when using QuickMap. App opens okay (but with map in wrong location). If selecting an area of interest via pull down (e.g. Los Angeles) the app will crash.

OS: LineageOS 14.1 for microG
microG version: GmsCore-v0.2.7.17455-mapbox.apk
Application: https://play.google.com/store/apps/details?id=gov.caltrans.quickmap

06-15 16:50:56.449  5570  5588 D SafeParcel: Unknown field num 10 in com.google.android.gms.common.internal.GetServiceRequest, skipping.
06-15 16:50:56.449  5570  5588 D GmsLocManagerSvc: bound by: GetServiceRequest{serviceId=LOCATION_MANAGER, gmsVersion=11020000, packageName='gov.caltrans.quickmap', extras=Bundle[{client_name=locationServices}]}
06-15 16:50:56.568  3003  3421 I ActivityManager: Displayed gov.caltrans.quickmap/.MapsActivity: +798ms
06-15 16:50:56.695 10005 10005 D AndroidRuntime: Shutting down VM
06-15 16:50:56.699 10005 10005 E AndroidRuntime: FATAL EXCEPTION: main
06-15 16:50:56.699 10005 10005 E AndroidRuntime: Process: gov.caltrans.quickmap, PID: 10005
06-15 16:50:56.699 10005 10005 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'void com.google.android.gms.maps.GoogleMap.setMyLocationEnabled(boolean)' on a null object reference
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at gov.caltrans.quickmap.MapsActivity.zoomToLocation(MapsActivity.java:931)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at gov.caltrans.quickmap.MapsActivity.onConnected(MapsActivity.java:1313)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.common.internal.zzac.zzn(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.internal.zzbcp.zzm(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.internal.zzbcd.zzpY(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.internal.zzbcd.onConnected(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.internal.zzbcx.onConnected(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.internal.zzbbi.onConnected(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.common.internal.zzaa.onConnected(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.common.internal.zzn.zzrj(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.common.internal.zze.zzs(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.common.internal.zzi.zzrk(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.google.android.gms.common.internal.zzh.handleMessage(Unknown Source)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:102)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:154)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6186)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
06-15 16:50:56.699 10005 10005 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
06-15 16:50:56.704  3003  4857 W ActivityManager:   Force finishing activity gov.caltrans.quickmap/.MapsActivity

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in MapsActivity.java at zoomToLocation(MapsActivity.java:931) and onConnected(MapsActivity.java:1313), then compare the behavior with commit 73fd85a8c7ff2762dd615f3a5caa9d9f1db2b6f5. Reproduce the QuickMap area-selection flow using the MapBox variant; done means selecting an area such as Los Angeles no longer crashes.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.