microg / microg/GmsCore

Build scripts incompatible with Java 9

Open
#729 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Build script
Dominant language
Java
Stars
14.6k
Forks
3.2k
Avg merge
12d 11h
Merged PRs (30d)
4

Description

The packaged Android.mk is incompatible with Pie builds since the prebuilt JDK packaged with the ASOP is now version 9, which the included gradle scripts do not support. This leads to a build failure, with result

[  0% 132/92470] build packages/apps/GmsCore/play-services-co...d/outputs/apk/release/play-services-core-release-unsigned.apk
FAILED: packages/apps/GmsCore/play-services-core/build/outputs/apk/release/play-services-core-release-unsigned.apk 
/bin/bash -c "(rm -Rf packages/apps/GmsCore/play-services-core/build ) && (mkdir -p /home/pants/dev/lineage-microg-docker-volumes/src/LINEAGE_16_0/out/target/common/obj/APPS/GmsCore_intermediates ) && (ln -s /home/pants/dev/lineage-microg-docker-volumes/src/LINEAGE_16_0/out/target/common/obj/APPS/GmsCore_intermediates packages/apps/GmsCore/play-services-core/build ) && (echo \"sdk.dir=/opt/android-sdk\" > packages/apps/GmsCore/local.properties ) && (cd packages/apps/GmsCore && git submodule update --recursive --init ) && (cd packages/apps/GmsCore/play-services-core && JAVA_TOOL_OPTIONS=\" -Dfile.encoding=UTF8\" ../gradlew assembleRelease )"
Picked up JAVA_TOOL_OPTIONS:  -Dfile.encoding=UTF8

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':microg-ui-tools'.
> java.lang.NullPointerException (no error message)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s

It would be nice if the build system were updated.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/apps/GmsCore/Android.mk, the Gradle scripts under packages/apps/GmsCore, and the microg-ui-tools project referenced by the failure. Run packages/apps/GmsCore/gradlew assembleRelease with the Java 9 environment to reproduce the configuration error. Done means the Android Pie build completes without the NullPointerException.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
build-system, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.