Geizhals: crash during app use
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 14.6k
- Forks
- 3.2k
- Avg merge
- 12d 11h
- Merged PRs (30d)
- 4
Description
Hello,
I hope this isn't a copy of an already existing issue. If so, please close/delete :)
• Android 8.1
• microgG 0.2.6.13280
• The app is mostly working fine but crashing, when selecting offer details.
Logcat:
<<< log_count = 8 >>>
[10-16 20:35:52.142 6892:6892 D/GeizhalsApiService]
onGenericDataLoad: GenericLoadDataEvent{mDataEnum=GET_PRODUCT, mRequestData=at.geizhals.pv.model.rest.request.product.ProductRequest@32ecb0}
[10-16 20:35:52.354 6892:6892 I/chatty]
uid=10161(at.geizhals.pv) identical 3 lines
[10-16 20:35:52.427 6892:6892 E/AndroidRuntime]
FATAL EXCEPTION: main
Process: at.geizhals.pv, PID: 6892
java.lang.SecurityException: Neither android.permission.ACCESS_COARSE_LOCATION nor android.permission.ACCESS_FINE_LOCATION granted.
at org.microg.gms.maps.GoogleMapImpl.setMyLocationEnabled(GoogleMapImpl.java:443)
at com.google.android.gms.maps.internal.IGoogleMapDelegate$Stub.onTransact(IGoogleMapDelegate.java:285)
at org.microg.gms.maps.GoogleMapImpl.onTransact(GoogleMapImpl.java:617)
at android.os.Binder.transact(Binder.java:627)
at com.google.android.gms.maps.internal.IGoogleMapDelegate$zza$zza.setMyLocationEnabled(Unknown Source:25)
at com.google.android.gms.maps.GoogleMap.setMyLocationEnabled(Unknown Source:2)
at at.geizhals.pv.content.merchant.MerchantOverviewFragment$5.onMapReady(MerchantOverviewFragment.java:758)
at com.google.android.gms.maps.MapView$zza$1.zza(Unknown Source:7)
at com.google.android.gms.maps.internal.zzm$zza.onTransact(Unknown Source:28)
at android.os.Binder.transact(Binder.java:627)
at com.google.android.gms.maps.internal.IOnMapReadyCallback$Stub$Proxy.onMapReady(IOnMapReadyCallback.java:79)
at org.microg.gms.maps.MapViewImpl$1.run(MapViewImpl.java:117)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
[10-16 20:35:52.577 1035:1046 W/ActivityManager]
Force finishing activity at.geizhals.pv/.MainActivity
[10-16 20:35:52.644 1035:1067 I/ActivityManager]
Showing crash dialog for package at.geizhals.pv u0
[10-16 20:35:53.097 1035:1066 W/ActivityManager]
Activity pause timeout for ActivityRecord{160a696 u0 at.geizhals.pv/.MainActivity t1158 f}
[10-16 20:35:55.155 1035:1046 W/ActivityManager]
Force finishing activity at.geizhals.pv/.MainActivity
[10-16 20:35:55.274 1035:1046 I/ActivityManager]
Killing 6892:at.geizhals.pv/u0a161 (adj 902): crash
EDIT: It's working, when manually granting the location permission in system settings for this app.
But shouldn't there be a permission request dialogue for this?
(I'm pretty sure I could use this app without location permission before when using Play Services)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the crash path in org.microg.gms.maps.GoogleMapImpl.setMyLocationEnabled and the app-side call at MerchantOverviewFragment.java:758. Reproduce the offer-details flow on Android 8.1 without location permission and inspect how permission state is handled. Done means the flow no longer crashes and the expected permission behavior is verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100