microg / microg/GmsCore

com.google.android.gms.wallet is included in play-services-base

Open
#3,754 2 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Java
Stars
14.6k
Forks
3.2k
PR merge metrics
PR metrics pending

Description

**Describe the bug**

#3507 has introduced *com.google.android.gms.wallet* classes and they were included in *play-services-base* instead of their own module - any project depending on a microG's lib now fetch these classes too.

We saw that with IzzyOnDroid analysis process on Passchain, which uses fido-core lib.

**Expected behavior**
Wallet classes should be in their own module.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting the changes from #3507 and the module declarations for play-services-base and the wallet classes. Confirm how the build currently packages com.google.android.gms.wallet, then verify that the wallet classes are isolated in their own module and are no longer fetched through play-services-base.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
build-system, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.