microg / microg/GmsCore

Add a /product path for microg.xml search path to comply with strict build requirements

Open Beginner friendly
#2,852 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
14.6k
Forks
3.2k
Avg merge
12d 11h
Merged PRs (30d)
4

Description

Is your feature request related to a problem? Please describe.

In LineageOS, and other distributions relying on lineageos4microg project to include microG, we are having issues with using a /system-based path to find the microg.xml in builds that are marked as strict which doesn't let system partition to have much additions, see https://github.com/lineageos4microg/android_vendor_partner_gms/issues/44

However, in microG, putting a /system/etc/microg.xml is the only way to provide build-time default settings.

Describe the solution you'd like

Another path such as /product/etc/microg.xml can be added such that microG checks that first and if it doesn't exist, then fall back to /system/etc/microg.xml so that no existing builds break and we can switch to /product/etc/microg.xml in future builds.

Describe alternatives you've considered

We tried to add it as exception but it doesn't work in strict builds https://github.com/lineageos4microg/android_vendor_partner_gms/pull/46

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with SettingsProvider.kt at the linked lookup for /system/etc/microg.xml and inspect how the default settings file is located. Support /product/etc/microg.xml as the preferred path while retaining the existing /system/etc/microg.xml fallback; done means both strict product-based builds and existing system-based builds can find the file.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java, kotlin
Domain
mobile
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.