microg / microg/GmsCore

Remove temporary asset module files as early as possible

Open
#2,674 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

📦 Asset Modules confirmed enhancement
Dominant language
Java
Stars
14.6k
Forks
3.2k
Avg merge
12d 11h
Merged PRs (30d)
4

Description

Follow up from #2506

To make sure we don't require more disk space than strictly needed to download assets, we should make an attempt to download temporary files from asset module downloads as early as possible.
See https://github.com/microg/GmsCore/pull/2506/files#diff-86f4eabecedcf18b6fb1492c68bdaad2852bc161ad4366c43672511882366aa9R134

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the asset module download code referenced in PR #2506, especially the diff around line 134, and trace when temporary files are created and consumed. Done means the implementation attempts to remove temporary asset files as early as possible while preserving successful downloads and reducing required disk space.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.