Asset Modules download cancellation incomplete
Open
Nobody has claimed this yet.
📦 Asset Modules
bug
confirmed
- Dominant language
- Java
- Stars
- 14.6k
- Forks
- 3.2k
- Avg merge
- 12d 11h
- Merged PRs (30d)
- 4
Description
Follow up from #2506
Downloads are not yet cancelled:
- immediately on request, but only after the current chunk is fully downloaded
- if the app requests download cancellation on its own (see https://github.com/microg/GmsCore/pull/2506/files#diff-86f4eabecedcf18b6fb1492c68bdaad2852bc161ad4366c43672511882366aa9R220)
- if the app notifies of a session failure (see https://github.com/microg/GmsCore/pull/2506/files#diff-86f4eabecedcf18b6fb1492c68bdaad2852bc161ad4366c43672511882366aa9R167)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the changes in pull request #2506, especially the referenced locations for download cancellation and session failure handling. Trace the Asset Modules download flow and verify cancellation occurs immediately, when requested by the app, and after a session failure; the issue is complete when all three cases stop the download promptly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100