microg / microg/GmsCore

Disallow unreasonable states in the backend (Google registration: off, Cloud messaging: on)

Open
#2,574 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
14.6k
Forks
3.2k
Avg merge
12d 11h
Merged PRs (30d)
4

Description

@mar-v-in

Quote:

I haven't looked at the network activity itself, but at the very least, having cloud messaging turned on is allowing the connection to Google to happen. Usually, the UI prevents having registration off and cloud messaging on, but apparently only the UI prevents this, and it's not prevented on the backend. So, cloud messaging can technically function in some form with the registration toggle off - not without some serious problems, though, as @cde pointed out in earlier comments.

See here: https://gitlab.com/CalyxOS/calyxos/-/issues/2674

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the backend handles the registration and cloud messaging settings described in the issue, using the linked CalyxOS issue for context. Verify what happens when registration is off and cloud messaging is on; done means the backend no longer permits this unreasonable combination and the behavior is covered by an appropriate check.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
backend, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.