I have identified two issues.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 14.6k
- Forks
- 3.2k
- Avg merge
- 12d 11h
- Merged PRs (30d)
- 4
Description
I have identified two issues.
1, The function org.microg.gms.auth.signin.AuthSignInActivity.finishResult should pass -1 as the first argument to setResult in case of success, but it is passing 0.
setResult(statusCode, data) change to setResult(RESULT_OK, data)
2, Are the lines 68 and 69 in the org.microg.gms.auth.signin.AuthSignInActivity.onCreate function intentionally filtering behavior? They seem to cause a failure in signing in with scopes.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in org.microg.gms.auth.signin.AuthSignInActivity, examining finishResult and the lines 68-69 of onCreate. Verify the success path uses RESULT_OK and investigate whether the onCreate filtering causes sign-in failures with scopes; done means both reported behaviors are resolved or the filtering is confirmed intentional.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100