Third ABI for legacy devices
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 14.6k
- Forks
- 3.2k
- Avg merge
- 12d 11h
- Merged PRs (30d)
- 4
Description
@mar-v-in
On device with Android < Lollipop can you please also add ro.product.cpu.upgradeabi, in addition of ro.product.cpu.abi and ro.product.cpu.abi2 for the abi list?
https://github.com/microg/GmsCore/blob/2d1395936836ae81d680736bc2175bb691d20b53/play-services-base/core/src/main/java/org/microg/gms/common/DeviceConfiguration.java#L112
PS: It should be valid but just to be safe maybe check that it isn't empty, isn't unknown and that it is different from abi and abi2.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in play-services-base/core/src/main/java/org/microg/gms/common/DeviceConfiguration.java around line 112 and inspect how the existing ABI properties are collected. Add support for ro.product.cpu.upgradeabi on Android versions below Lollipop, accepting it only when non-empty, known, and distinct from the first two ABIs. Done means the resulting ABI list includes the third value only when valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100