microg / microg/GmsCore

[org.thoughtcrime.securesms] Push notifications, priority is changed to PRIORITY_UNKNOWN

Open
#1,745 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
14.6k
Forks
3.2k
Avg merge
12d 11h
Merged PRs (30d)
4

Description

Affected app
Name: [Signal]
Package id: [org.thoughtcrime.securesms]

Describe the bug
Push notification priority is changed to PRIORITY_UNKNOWN.
During the discussion regarding a push notification issue https://github.com/signalapp/Signal-Android/issues/12325 for Signal (which has been fixed) a Signal developer noted that their push notification priority https://github.com/signalapp/Signal-Android/issues/12325#issuecomment-1175191259 is changed from high-priority to PRIORITY_UNKNOWN. Also a developer of ShiftOS stated that with the ShiftOS-L flavor there are no GMS available and they are not changing any priority https://github.com/signalapp/Signal-Android/issues/12325#issuecomment-1176118333 the question arose if this might be an issue with microG.

I noticed that there was this issue https://github.com/microg/GmsCore/issues/338 requesting to put the app into a temporary whitelist when a high-priority push message is retrieved which might be related. However the pull request https://github.com/microg/GmsCore/pull/732 for the implementation was already resolved long ago in commit https://github.com/microg/GmsCore/commit/60023887d101a272f01425bf7f130576960acd50.

Would be great if you could share any insight regarding this behaviour.

System
Android Version: [10]
Custom ROM: [ShiftOS-L 3.7 (20220511)]

microG
microG Core version: [v0.2.24.214816]
microG Self-Check results: [All ticked]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Signal issue #12325 and its referenced comments, then review microG issue #338, pull request #732, and commit 60023887d101a272f01425bf7f130576960acd50. Reproduce the priority behavior on the stated Android and microG versions if possible; done means identifying whether microG changes the priority and documenting the cause or a concrete next step.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, firebase, java
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.