Checking deprecated permission.C2D_MESSAGE possibly breaking cloud messages
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 14.6k
- Forks
- 3.2k
- Avg merge
- 12d 11h
- Merged PRs (30d)
- 4
Description
Hi.
(Sorry for bad English)
User Dark Simpson asked interesting question in a microG thread on 4pda
>> URL <<
He suggested that telegram app does not receive cloud messages correctly due to a missing deprecated C2D_MESSAGE permission check.
So do we really need to check this permission ?
Migrating from Google Cloud Messaging (GCM) to Firebase Cloud Messaging (FCM)
And one more question from me:
Is it normal that whitelisting doesn't happen for third party apps?
https://github.com/microg/GmsCore/blob/a830b5dd5de71fa53f9d037c210a81fb38ea3321/play-services-core/src/main/java/org/microg/gms/gcm/McsService.java#L561-L570
Or have I misunderstood something?
Thanks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with play-services-core/src/main/java/org/microg/gms/gcm/McsService.java, especially the permission check at lines 535-546 and whitelisting logic at lines 561-570. Compare those behaviors with the linked GCM-to-FCM migration context and determine whether deprecated C2D_MESSAGE checks or third-party-app whitelisting explain the reported Telegram cloud-message issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, firebase, java
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100