microg / microg/GmsCore

[com.google.android.gms] @dirty@30Mar2021 : Crash instead of push notification confirmation

Open
#1,430 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
14.6k
Forks
3.2k
Avg merge
12d 11h
Merged PRs (30d)
4

Description

Affected app
Name: GmsCore [0.2.18.204714-dirty] built from source @ 30 Mar 2021
Package id: com.google.android.gms

Describe the bug
microG crashes when app asking to register on push notification service with "Ask before registering a new app to receive push notifications" option enabled. Error exists after commit https://github.com/microg/GmsCore/commit/91b0f6893f9848354af7654b3cebc842615bcd7f

To Reproduce
Steps to reproduce the behavior:

  1. Enable "Ask before registering a new app to receive push notifications"
  2. Run any newly installed app which would try to register on push notification service
  3. Catch error

System
Android Version: 7.1.3
Stock ROM: Sony Xperia Z5 Compact E5823 32.4.A.1.54

microG
microG Core version: [0.2.18.204714-dirty] built from source @ 30 Mar 2021
microG Self-Check results: [All ticked]

Logcat

Description:java.lang.RuntimeException: Unable to start activity ComponentInfo{com.google.android.gms/org.microg.gms.ui.AskPushPermission}: android.view.InflateException: Binary XML file line #61: Binary XML file line #61: Error inflating class

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the changes in commit 91b0f6893f9848354af7654b3cebc842615bcd7f and inspect the AskPushPermission activity and its layout around binary XML line 61. Reproduce the flow with push-registration confirmation enabled and verify that the confirmation screen opens without the InflateException.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.