microcks / microcks/microcks-cli

fix(security): credential redaction in 0f8b000 misses JSON bodies access_token, refresh_token, clientSecret, and password print verbatim with --verbose

Open Beginner friendly
#503 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/cli kind/bug
Dominant language
Go
Stars
52
Forks
68
Avg merge
6h 54m
Merged PRs (30d)
10

Description

## Problem

i added credential redaction to verbose HTTP dumps. It works for `Authorization` headers but misses both places where secrets actually appear.

**Leak 1 Keycloak token response** (`keycloak_client.go:96`)

The response body is JSON. The regex expects `name=value` (form encoding), so `"access_token":"eyJ..."` prints verbatim.

**Leak 2 create-test request body** (`microcks_client.go:371`)

`OAuth2ClientContext` is marshalled into the POST body. Fields `clientSecret`, `password`, and `refreshToken` aren't in the pattern at all.

The header redaction fires correctly, which is exactly what makes this easy to miss:
```
Authorization: [REDACTED] ← works
{"oAuth2Context":{"clientSecret":"SECRET","password":"SECRET",...}} ← leaks
```

## Root Cause

```go
// only matches name=value — never fires on JSON bodies
var sensitiveParamPattern = regexp.MustCompile(
`(?i)(access_token|refresh_token|id_token|code)=([^&\s]+)`,
)
```

Apply it alongside the existing patterns in `redactSensitiveContent`.

## Reproduce

Drop into `pkg/config/redact_probe_test.go` and run `go test ./pkg/config/ -run TestRedactProbe -v` — 6 FAILs, all confirmed against the real function.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with redactSensitiveContent and the existing patterns, then run pkg/config/redact_probe_test.go using go test ./pkg/config/ -run TestRedactProbe -v. Check the call sites noted in keycloak_client.go:96 and microcks_client.go:371. Done means the six probe failures pass and access_token, refresh_token, clientSecret, and password no longer print verbatim in verbose output.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.