microcks / microcks/microcks-cli
Bug : DownloadArtifact reading request body instead of response body
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 52
- Forks
- 68
- Avg merge
- 6h 54m
- Merged PRs (30d)
- 10
Description
### Describe the bug
The `DownloadArtifact` function incorrectly reads from **req.Body** instead of **resp.Body** after executing the HTTP request.
## Current implementation:
`respBody, err := io.ReadAll(req.Body)`
This causes the function to read the request payload rather than the server response body, which may lead to empty or invalid artifact content when using import-url functionality.
## Expected behavior:
Microcks has discovered 'SUCCESS_FROM_SERVER'
## Actual behavior:
Microcks has discovered ''
### How to Reproduce?
_No response_
### Microcks version or git rev
_No response_
### Install method (`docker-compose`, `helm chart`, `operator`, `docker-desktop extension`,...)
_No response_
### Additional information
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the DownloadArtifact function and inspect the HTTP response handling after the request is executed, especially the import-url path. Verify that artifact content comes from the server response and reproduces the expected SUCCESS_FROM_SERVER result rather than an empty value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, cli
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100