micro-editor / micro-editor/micro

micro killed by a diacritic

Open
#769 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
29.6k
Forks
1.4k
Avg merge
2d 18h
Merged PRs (30d)
10

Description

The problem is fully described by this screen shot:

screen shot 2017-08-03 at 19 37 00

With the contents of the buffer as shown, I tried to add a diacritic (highlighted in the menu to the right) to the last symbol, and micro crashed.

Commit hash: fad95c0
OS: Mac OS
Terminal: iTerm2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the crash using the buffer and diacritic shown in the screenshot, at commit fad95c0 on Mac OS with iTerm2. Trace the failing input path from that reproduction; the work is done when adding the diacritic no longer crashes micro and the regression is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.