micro-editor / micro-editor/micro
config.SetGlobalOption no longer allows writing to settings.json
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 29.6k
- Forks
- 1.4k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 10
Description
Description
In https://github.com/micro-editor/micro/pull/3618, the ability for plugins to save settings was removed entirely. Surely this should be configurable, as some plugins depend on this capability?
The relevant code from action/command.go is below. Why not add a third argument writeToFile that gets passed through to SetGlobalOption instead of hard-coding false? I'd be happy to submit a PR.
func SetGlobalOptionPlug(option, value string) error {
return SetGlobalOption(option, value, false)
}
Environment
- Version:
- OS:
- Terminal:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in action/command.go at SetGlobalOptionPlug and trace SetGlobalOption, comparing the current behavior with the change introduced in pull request 3618. Check how plugin option updates are handled and how settings.json persistence is tested or exercised. Done means plugins can explicitly control whether global options are written to settings.json without changing the default behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100