micro-editor / micro-editor/micro

Does log pane must have one instance?

Open
#3,098 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
29.6k
Forks
1.4k
Avg merge
2d 18h
Merged PRs (30d)
10

Description

Does log pane must have one instance?

https://github.com/zyedidia/micro/blob/2d82362a6695a7e898455ce016449167ac439ddd/internal/action/globals.go#L8-L9

log don't check if log buffer is open it just checks if you ran it from log buffer.

> log
Ctrl+w to switch to non logbuf
> log

It looks like a sorta bug. We have only one pointer for global LogBufPane so we must have only one log pane at the moment(?) Am I right it is a bug? @dmaluka @JoeKar

It is easy to correct for > log https://github.com/dustdfg/micro/commit/da2d4cf56d92a7fd51da5aed569a931a4b1bb2d0 but I am not sure what to do with

https://github.com/zyedidia/micro/blob/2d82362a6695a7e898455ce016449167ac439ddd/internal/action/globals.go#L30-L36

Does comment rely on the fact it is opened only by ToggleLogCmd?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with internal/action/globals.go at the LogBufPane references and inspect ToggleLogCmd, then reproduce the two-log sequence described in the issue. Trace how the log buffer is opened and switched to determine whether multiple log panes are supported. Done means the intended log-pane behavior is explicit and the affected command and global-state handling are consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.