Crash when opening a file using the fzf command to fuzzy find

Open

#2,649 opened on Nov 30, 2022 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language: Go
Stars: 29.6k
Forks: 1.4k
Avg merge: 2d 18h
Merged PRs (30d): 10

Description

Description of the problem or steps to reproduce

When using the fzf command to fuzzy open a file, micro keeps crashing. Here is a backtrace of the panic:

Micro encountered an error: runtime.errorString runtime error: invalid memory address or nil pointer dereference
runtime/panic.go:260 (0x564e210a9e56)
runtime/panic.go:259 (0x564e210a9e26)
github.com/zyedidia/micro/v2/internal/screen/screen.go:104 (0x564e21485d8a)
github.com/zyedidia/micro/v2/internal/display/statusline.go:189 (0x564e214e8ee5)
github.com/zyedidia/micro/v2/internal/display/bufwindow.go:726 (0x564e214e431d)
github.com/zyedidia/micro/v2/internal/display/bufwindow.go:776 (0x564e214e48a8)
github.com/zyedidia/micro/v2/cmd/micro/micro.go:395 (0x564e21535574)
github.com/zyedidia/micro/v2/cmd/micro/micro.go:382 (0x564e21534e12)
runtime/proc.go:250 (0x564e210968d3)
runtime/asm_amd64.s:1594 (0x564e210c5501)

If you can reproduce this error, please report it at https://github.com/zyedidia/micro/issues

Specifications

Version: 2.0.11
Commit hash: 225927b9
Compiled on August 09, 2022
OS: Garuda Linux (arch)
Terminal: alacritty (fish)

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start by reproducing the crash with the fzf command, then trace the backtrace through internal/screen/screen.go, internal/display/statusline.go, internal/display/bufwindow.go, and cmd/micro/micro.go. Confirm the fix by opening a file through fuzzy finding without the nil-pointer panic, and add or update regression coverage if the existing test structure supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack: go
Domain: cli
Issue type: Bug
Difficulty: 3/5
Estimated time: 1-2 days
Activity status: Stale
Clarity: Mostly clear
Newbie friendliness: 45/100