micro-editor / micro-editor/micro

Micro opens DOS format files as UNIX format

Open
#2,260 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
29.6k
Forks
1.4k
Avg merge
2d 18h
Merged PRs (30d)
10

Description

Description of the problem or steps to reproduce

  • The option "fileformat": "dos" is correctly set in <settings.json>.
  • When creating new files, Micro correctly creates and saves as DOS, and opens the same file as DOS.
  • But then, I open any file with the DOS format (CRLF) and it's actually opened as UNIX, and saved as UNIX.
  • Micro doesn't seem to correctly recognize CRLF.

2021-11-02 20 46 05
2021-11-02 20 46 08

However, after the previous test I added a fifth empty line and Micro now sees the file correctly as DOS:

2021-11-02 20 47 13
2021-11-02 20 47 35

So.. Micro seems to only recognize and save to the DOS format if there's a CRLF at the end, an empty line. But this is a problem.. I've tried about a dozen of scripts and it almost always wrongfully sets the UNIX format. In fact, I noticed this after Micro had changed a bunch of files I had been working on, changing them to the UNIX format.

Specifications

Commit hash: b9763856
OS: Windows 10
Terminal: ConEmu/CMD/PowerShell

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the problem with a short CRLF file on the stated Windows terminal environments, comparing files with and without a final empty line. Then trace Micro's file-format detection and saving behavior; done means existing CRLF files are recognized and saved as DOS without requiring a trailing empty line.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.