micro-editor / micro-editor/micro

`Unsplit` does not have the expected behavior

Open
#2,045 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
29.6k
Forks
1.4k
Avg merge
2d 18h
Merged PRs (30d)
10

Description

Description of the problem or steps to reproduce

Unsplit does not have the expected behavior. Unsplit should close all splits in the current tab except the active one as described in the code here:
https://github.com/zyedidia/micro/blob/de8f4bf72f20313326f7b2666efadf49bf1a433b/internal/action/actions.go#L1569

Instead, it closes the active split and resizes the others.

Step to reproduce

  • Assign keybinding to Unsplit action in bindings.json
  • Restart micro
  • Open multiple splits
  • Use previously assigned keybinding
  • micro close active split

Specifications

Commit hash: cfcb2e45
OS: Manjaro 20.2.1
Terminal: URxvt

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with internal/action/actions.go at the linked Unsplit action, then reproduce the behavior using a keybinding in bindings.json with multiple splits. Done means Unsplit closes every split in the current tab except the active one, rather than closing the active split and resizing the others.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.