micro-editor / micro-editor/micro
Git diff gutter does not work correctly for files with windows line endings (CRLF)
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 29.6k
- Forks
- 1.4k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 10
Description
Description of the problem or steps to reproduce
When opening a git versioned file containing windows line endings (CRLF), the git diff gutter shows all lines as modified. This happens with the native windows binary, and the linux binary via WSL.
Specifications
Version: 2.0.1
Commit hash: 7c71995
Compiled on February 12, 2020
OS: Windows 10 (Version 1903)
Terminal: Cmd / Windows Terminal / Conemu
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by opening a Git-versioned CRLF file in the Windows or WSL binary and observing the diff gutter. Trace the git diff gutter handling to find where line endings are compared; done means unchanged CRLF lines are no longer reported as modified while real changes still appear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100