micro-editor / micro-editor/micro
JS syntax highlighting thinks quotes inside of a regular expression should be treated as string quotes
Open
Nobody has claimed this yet.
bug
syntax
- Dominant language
- Go
- Stars
- 29.6k
- Forks
- 1.4k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 10
Description
Description of the problem or steps to reproduce
If you have a quote in a regular expression, it treats the quote as the opening of a string, and makes the rest of the file unreadable.
Specifications
Here's an image:
Here's some example code you can use:
console.log("great!");
if (`Does this string have quotes? Let's find out`).match(/['"]/)) {
console.log("Looks like it does");
}
Commit hash: af520cf
OS: macOS High Sierra
Terminal: iTerm2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the syntax-highlighting problem with the JavaScript example in the issue, especially the quote inside /['"]/. Trace the syntax-highlighting entry point for JavaScript and verify that quotes inside a regular expression no longer cause the remainder of the file to be treated as a string.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100