micro-analytics / micro-analytics/micro-analytics-cli
atomicity and db operation concerns
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 732
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Description
So as a few people have brought up, we are mimicking locking in our pushView util function which seems to be doing the db adapter's job. For example, if a db solution supports a "add or increment" function or handles atomicity cross process, then we are introducing a performance bottleneck by having all adapters use our locks logic and 2-3 transaction inserts. For the record, I think it was a really good starting point but we should take it to the next level.
So, I think that the next phase of our adaptors, while there are only two, need to support the API that we provided but the put needs to be changed. If they need to manually call their this.has() and this.get() to reconcile what they need to do, then go for it, but we shouldn't force that. So we should change put (or possibly rename it) but we should give them the key and they need to resolve a promise with the count value.
What do you think?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the pushView utility and the two database adapters, then trace how their current put operation performs has/get checks, locking, and transaction inserts. Decide the adapter-facing put contract, including how it receives the key and resolves the count, while preserving the existing API where required. Done means both adapters support the agreed atomic-operation behavior without forced shared locking.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100