michaelpb / michaelpb/omnic

Sophisticate-ify domain checking, integrate into security module

Open
#30 0 comments 0 reactions 0 assignees View on GitHub
CodeQuality enhancement Settings
Dominant language
Python
Stars
16
Forks
1
PR merge metrics
No merged PRs in 30d

Description

* Should also add in URL reversal to utils/urls.py
* Have it respect the security thing in use

```
security.py
51 async def check(typestring, querydata):
52 if singletons.settings.SECURITY is not None:
53 checker_class = singletons.settings.load('SECURITY')
54 else:
55 checker_class = DummySecurity
56 checker = checker_class()
57 url_string = querydata['url'][0]
58 foreign_res = ForeignResource(url_string)
59 foreign_res.validate() # TODO move domain checks into this module
60 await checker.check(typestring, querydata)
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with security.py around check() and the TODO for moving domain checks, then inspect utils/urls.py and ForeignResource. Determine how URL reversal and the configured SECURITY checker should interact; done means domain checking is integrated there, URL reversal is supported, and the active security implementation is respected.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.