michaelpb / michaelpb/omnic

Clean up testing to use use_settings decorator etc

Open
#29 0 comments 0 reactions 0 assignees View on GitHub
CodeQuality enhancement
Dominant language
Python
Stars
16
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Older tests are a mess, clean up to be much more mocked and not as integrate-y, also use decorators

```
37 def __init__(self, use_settings=None):
38 if use_settings:
39 # Used by testing, TODO remove
40 self.placeholders = use_settings.PLACEHOLDERS
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the older tests and the __init__ method containing the use_settings parameter and PLACEHOLDERS assignment. First inventory which tests depend on integration behavior, then review existing mocking and decorator patterns in the test suite. Done means the affected tests use the established decorator and mocking approach rather than the current integration-heavy setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.