michaelbromley / michaelbromley/angularUtils

dirPagination:hide() is not working in navigation

Open
#473 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2k
Forks
842
PR merge metrics
No merged PRs in 30d

Description

Description of issue:
I have hide an tag in page1 .Then I navigate to page2,page3 .Once I came back to page1 the hidden icon is visible.

Steps to reproduce:

Expected result:
Hidden icons shouldn't be visible.

Actual result:

Demo: (for dirPagination, fork and modify this Plunk: http://plnkr.co/edit/b37IdFFJUokaeSummETX?p=preview)

Any relevant code:


Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the linked dirPagination Plunk demo: hide an anchor tag on page 1, navigate through pages 2 and 3, then return to page 1. Inspect the dirPagination navigation behavior involved in restoring page contents. Done means hidden icons remain hidden after changing pages and returning to page 1.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.