michaelbromley / michaelbromley/angularUtils

dirPagination: $index does not display properly over multiple pages.

Open
#444 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2k
Forks
842
PR merge metrics
No merged PRs in 30d

Description

Hi there,

I found that $index will not accumulate past the actual page per number count, so u cannot tell them index from your object properly.

I made a plunker where it shows that every page has $index going from 0 to 9 instead of properly going up.

http://plnkr.co/edit/kFR4SUptZowapfJKBy6F?p=preview

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Plunker and reproduce the dirPagination behavior across multiple pages. Trace the pagination directive's handling of $index and compare the displayed positions between pages. Done means the index continues across page boundaries rather than resetting from 0 to 9 on every page.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.