michaelbromley / michaelbromley/angularUtils
dirDisqus: dsq.src with custom protocol
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2k
- Forks
- 842
- PR merge metrics
- No merged PRs in 30d
Description
Hello Michael,
First, thank you for nice directive. Now, I have issue with protocol-relative URL for dsq.src (dirDisqus.js
-> line 69). When using your directive for my PhoneGap app it applies "file://" instead needed "http(s)://". Can you add optional disqus_protocol property to disqusConfig object and if exist apply it on dsq.src in your directive? -It would fix my issue and probably help someone else as well.
angular-utils-disqus: 1.0.1
Thank you!
Regards.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at dirDisqus.js line 69 and inspect how dsq.src is formed from disqusConfig. Check the requested disqus_protocol property and the PhoneGap file:// behavior described in the issue. Done means the directive can use the configured protocol for dsq.src while preserving existing behavior when it is not provided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, javascript
- Domain
- frontend, web-dev
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100